Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Automatic-Module-Name' to all MANIFEST.MF #511

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sschulz92
Copy link
Contributor

This new attribute is required to move on to Java 9 or newer.

@fgdrf
Copy link
Contributor

fgdrf commented Sep 24, 2021

Not sure about this one at the moment since compile-level and source-level is still Java 1.8.

And I remember some clitches Michael mentioned I'd like to clarify first ;)

@sschulz92
Copy link
Contributor Author

sschulz92 commented Oct 28, 2021

I would like to raise awareness this PR again as @egouge also want to change the MANIFEST.MF in the same way I want to do it. See the PR of Emily: #575

Maybe we want to split the PR into dedicated changes, what do you think @egouge @fgdrf ?

@fgdrf
Copy link
Contributor

fgdrf commented Oct 28, 2021

I have no strong feeling abot one way or the other. I guess conflicts to the other PR are easy to resolve once joda-time fixes are on master.

Lets keep it as it is unless the other one is done. BTW: Is there a setting in eclipse to allow Automatic-Module-Name? Maybe its worth to document it in the Dev-guilde Eclipse IDE...

@egouge
Copy link
Contributor

egouge commented Oct 28, 2021

I didn't actively make these changes when making changes for the joda time update so I'm thinking the version of Eclipse I used made this change automatically (or maybe I did quick fix and didn't realize it).

Apparently they do have a quick fix:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=525660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants