Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure valid input to DepthSegment constructor in unit test #319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FObermaier
Copy link
Contributor

@FObermaier FObermaier commented Sep 25, 2018

Whilst struggling with an NTS issue related to BufferOp I noticed that the input for the DepthSegmentTest is not valid according to the assumptions made in the DepthSegment constructor:

public DepthSegment(LineSegment seg, int depth)
{
// input seg is assumed to be normalized
upwardSeg = new LineSegment(seg);
//upwardSeg.normalize();
this.leftDepth = depth;
}

This mentioned issue does not affect JTS.

@FObermaier FObermaier changed the title Ensure valid input to DepthSegment constructor inunit test Ensure valid input to DepthSegment constructor in unit test Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant