Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new kernels #3486

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add new kernels #3486

wants to merge 2 commits into from

Conversation

yang162132
Copy link

@yang162132 yang162132 commented Oct 28, 2022 •
edited

Overview

add some new kernel for focal calculate.

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • Module Hierarchy updated, if necessary
  • docs guides update, if necessary
  • New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

Demo

Optional. Screenshots/REPL

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Closes #XXX

pomadchin
pomadchin requested changes Feb 25, 2023
View reviewed changes
Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for a fantastic contribution, and sorry for a very dealyed review.

Could I ask you to adjust tests? So tests actually compare the computed result with some expected values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomadchin pomadchin pomadchin requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yang162132 @pomadchin