GEOMESA-3238 Support for Non-Normalized Heatmaps #2904
Draft
+182
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkearns-ccri
commented
Oct 18, 2022
mkearns-ccri
commented
- Adds normalization boolean to DensityProcess
- Updates density process documentation to reflect the change
- Adds scala implementation of the HeatmapSurface class
* Adds normalization boolean to DensityProcess * Updates density process documentation to reflect the change * Adds scala implementation of the HeatmapSurface class
mkearns-ccri
commented
Oct 18, 2022
|
|
||
| import org.locationtech.jts.geom.Envelope | ||
|
|
||
| class HeatmapSurface(kernelRadius: Int, |
There was a problem hiding this comment.
@elahrvivaz I basically just ripped this from geotools and added a ccri copyright header - not sure if this is okay or not. Unfortunately I had to copy the whole class because java doesn't allow overriding private methods. Thoughts?
There was a problem hiding this comment.
i was wondering about that too and i'm not sure of the answer - would it be possible to use the existing geotools classes, but track the max value when adding points, then de-normalize it afterwards? then we wouldn't have to worry about it
There was a problem hiding this comment.
I confirmed with @jnh5y that we're not allowed to copy and re-license geotools as it's LGPL, so we'll need to come up with a different solution here.
mkearns-ccri
commented
Oct 18, 2022
|
|
||
| import org.locationtech.jts.geom.Envelope | ||
|
|
||
| class GridTransform(env: Envelope, xSize: Int, ySize: Int, isClamped: Boolean = true) { |
elahrvivaz
requested changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.