add small quirks for new resource providers #10818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzon
added
the
semver: patch
pinzon
force-pushed
the
feat/cfn/quirks-for-wafv2-resources
branch
from
7d344bf
to
52f67f3
Compare
pinzon
requested review from
dominikschubert,
simonrw and
Morijarti
as code owners
simonrw
approved these changes
May 17, 2024
|
update: it looks like the spec is incomplete. There is no |
|
Alright, I'll go ahead with the merge. We can fix or add a better handling for that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds changes to allow the correct deployment of WAFv2 resource providers. These resources physical ids are composed like: Name|Id|Scope.
Also, trying to use the scaffolding tool to generate the files for WAFv2::WebACL throws a RecursionError.
Changes