Fix entrypoint script configurator encoding and line endings in windows #10814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfangl
added
semver: patch
dfangl
force-pushed
the
fix/entrypoint-configurator-windows
branch
from
37431ad
to
4ba9cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using the CLI in extension dev mode under windows, the custom container entrypoint file gets generated using windows file endings (
\r\n).This file is then mounted into the linux container, and fails to execute due to the wrong line endings.
To avoid this, we now force linux file endings for container entrypoints, and in addition utf-8 encoding, since some entrypoints (for example the extension dev mode one) contains unicode characters.
Changes