Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track cfn resource events #10760

Merged
merged 1 commit into from
May 29, 2024
Merged

Track cfn resource events #10760

merged 1 commit into from
May 29, 2024

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented May 3, 2024

Motivation

During the migration to resource providers, the event information telling us which resources are being used and which resources are not implemented was removed. This means we no longer get an accurate picture of CFn resource usage.

Changes

  • Emit both resource_type and missing_resource_types events at appropriate places

TODO

  • Test against -ext

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label May 3, 2024
@simonrw simonrw self-assigned this May 3, 2024
Copy link

github-actions bot commented May 3, 2024

LocalStack Community integration with Pro

  2 files    2 suites   21m 8s ⏱️
385 tests 274 ✅ 111 💤 0 ❌
387 runs  274 ✅ 113 💤 0 ❌

Results for commit 9e7729d.

♻️ This comment has been updated with latest results.

@simonrw simonrw marked this pull request as ready for review May 3, 2024 11:01
@simonrw simonrw merged commit 4cca291 into master May 29, 2024
30 checks passed
@simonrw simonrw deleted the cfn/re-enable-events branch May 29, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants