Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: manually update PyTorch version #3340

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

vivekkhandelwal1
Copy link
Collaborator

Set PyTorch and TorchVision version to nightly release 2024-05-14.

Signed-Off By: Vivek Khandelwal vivekkhandelwal1424@gmail.com

@vivekkhandelwal1
Copy link
Collaborator Author

vivekkhandelwal1 commented May 21, 2024

Hi @stellaraccident, the Roll PyTorch has been blocked on the below error since last week:

python exception: Failure while executing pass pipeline:
error: "/home/azureuser/work/torch-mlir-vivek/test/python/fx_importer/sparse_test.py":539:0: failed to legalize operation 'torch.operator'
note: "/home/azureuser/work/torch-mlir-vivek/test/python/fx_importer/sparse_test.py":539:0: see current operation: %2 = "torch.operator"(%1, %0, %0, %0) <{name = "torch.aten.to_sparse"}> : (!torch.vtensor<[2,2,2],f32>, !torch.none, !torch.none, !torch.none) -> !torch.vtensor<[2,2,2],f32>

For Torch-MLIR developers, the error can be reproduced with:
$ torch-mlir-opt -pass-pipeline='builtin.module(func.func(torch-decompose-complex-ops),torch-backend-to-linalg-on-tensors-backend-pipeline)' /tmp/UnnammedModule.mlir
Add '-mlir-print-ir-after-all -mlir-disable-threading' to get the IR dump for debugging purpose.

It seems that we need to add Torch Lowering for torch.aten.to_sparse. I don't think any such lowering exists before in the project. Can we support this? If yes, some advice on it would be helpful.

@stellaraccident
Copy link
Collaborator

Just create a PR to skip the test, and tag Aart on it. Either he can fix it quickly or we land it.

@vivekkhandelwal1 vivekkhandelwal1 force-pushed the roll-pytorch branch 2 times, most recently from 2a4b154 to c7590a2 Compare May 29, 2024 15:55
@vivekkhandelwal1
Copy link
Collaborator Author

Hi @stellaraccident, I have modified the failing test. But the issue is that the "Fixed Test for Nightly" is now failing for stable PyTorch.

@aartbik, do you have something in mind for this?

@vivekkhandelwal1
Copy link
Collaborator Author

Corresponding issue #3418

Set PyTorch and TorchVision version to nightly release 2024-05-29.
This commit also temporarily disables some of the tests in sparse_test.py.
These tests will be enabled again with a fix in a follow-up commit.

Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
@vivekkhandelwal1 vivekkhandelwal1 merged commit 72837fb into llvm:main Jun 6, 2024
3 checks passed
sjarus pushed a commit to sjarus/torch-mlir that referenced this pull request Jun 6, 2024
Set PyTorch and TorchVision version to nightly release 2024-05-14.

Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants