[RISCV] Add new "native" (qemu-system) builders #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asb
added a commit
that referenced
this pull request
May 22, 2024
Right now, extra_cmake_args to getClangCMakeBuildFactory are applied to both stage1 and stage2. But there are some cases where we would not want to use the same configs, e.g. flags that might not be understood by the current host compiler, or enabling ccache only for stage1 (the cache will never hit for stage2). Reviewed as part of #188.
These are now gated in clang as they should have been.
asb
force-pushed
the
2024q2-riscv-new-builders
branch
from
36f2c74
to
4495695
Compare
|
Thanks for the review, I've emailed you the builder passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For background, I don't expect these builders to graduate from the staging buildmaster in the current configuration. I'm spinning them up so we get some slow feedback while I, in parallel, explore alternative build configs that make better tradeoffs in terms of response time vs feedback.
These are all qemu-system based. Please note that the first commit adds a new ability to set cmake flags that apply only to the second-stage build, which I use to apply
-marchthat the system compiler may not understand as well as to have ccache enabled for the first stage only. Happy to split that out to a separate PR if you prefer.