Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Fix width of attribute in MuxPadSel canonicalizations. #7056

Merged
merged 1 commit into from
May 17, 2024

Conversation

dtzSiFive
Copy link
Contributor

Detected by -DMLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS=ON.

cc #7047.

Detected by -DMLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS=ON.

cc llvm#7047.
@dtzSiFive dtzSiFive added the FIRRTL Involving the `firrtl` dialect label May 16, 2024
@dtzSiFive
Copy link
Contributor Author

/home/will/src/sifive/circt/test/Dialect/FIRRTL/canonicalization.mlir:628:9: error: firrtl.constant attribute bitwidth doesn't match return type
  %16 = firrtl.mux (%val0, %val1, %val2) : (!firrtl.uint<0>, !firrtl.uint<1>, !firrtl.uint<1>) -> !firrtl.uint<1>
  ¦ ¦ ¦ ^
/home/will/src/sifive/circt/test/Dialect/FIRRTL/canonicalization.mlir:628:9: note: see current operation: %9 = "firrtl.constant"() {value = 0 : ui32} : () -> !firrtl.uint<1>
LLVM ERROR: IR failed to verify after pattern application

Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dtzSiFive dtzSiFive merged commit dc216e8 into llvm:main May 17, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the fix/firrtl-mux-pad-sel-intattr-width branch May 17, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants