[Sim] Add DPI func/call and lowering #7042
Open
+455
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
force-pushed
the
dev/hidetou/func-export
branch
3 times, most recently
from
ef06699
to
3767a5b
Compare
uenoku
force-pushed
the
dev/hidetou/dpi-sim
branch
4 times, most recently
from
c3ec8a7
to
7de08da
Compare
uenoku
force-pushed
the
dev/hidetou/dpi-sim
branch
from
7de08da
to
5e92614
Compare
uenoku
commented
Jun 5, 2024
Comment on lines
+91
to
+95
| p, op->getRegion(0), op.getModuleType(), | ||
| op.getPerArgumentAttrsAttr() | ||
| ? ArrayRef<Attribute>(op.getPerArgumentAttrsAttr().getValue()) | ||
| : ArrayRef<Attribute>{}, | ||
| SmallVector<Location>(getArgumentLocs().value().getAsRange<Location>())); |
There was a problem hiding this comment.
I'll refactor this ugly part...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DPI func/call op and SimToSV lowering.
sim.dpi.funcis a just bridge tosv.func. This op can be lowered intofunc.funcin the future for Arc integration.sim.func.dpi.callrepresents SystemVerilog DPI function call. There are two optional operandsclockandenable.If
clockis not provided, the callee is invoked when input values are changed. If provided, the dpi function is called at clock's posedge. The result values behave like registers and the DPI function is used as a state transfer function of them.enableoperand is used to conditionally call the DPI since DPI call could be quite more expensive than native constructs. Whenenableis low, results of unclocked calls are undefined and in SV results they are lowered intoX. Users are expected to gate result values by anotherenableto model a default value of results. For clocked calls, a low enable means that its register state transfer function is not called. Hence their values will not be modify in that clock.A function that returns an explicit return is not supported yet. I'll follow-up.