[FIRRTL][Import] Remove support for printf-encoded verif. #7030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retain logic to recognize (but not parse or diagnose) printf's of the various "flavors" previously supported so that we can reject designs that rely on this removed support (emit error).
|
This breaks compatibility with FIRRTL generated by not-latest Chisel, although this version will detect this and produce an error. Generally we've mostly kept backwards compatibility with both old FIRRTL and old Chisel-emitted constructs (annotations, etc), and anyway so should only land this if we're ready to change that 👍. (thoughts/input welcome, LMK 👍) |
uenoku
reviewed
May 14, 2024
Per reviewer feedback, thanks!
fabianschuiki
approved these changes
May 14, 2024
dtzSiFive
deleted the
feature/drop-printf-encoded-verif-but-keep-superficial-parsing
branch
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retain logic to recognize (but not parse or diagnose) printf's of the various "flavors" previously supported so that we can reject designs that rely on this removed support (emit error).
Similar to #7010, but retains logic for recognizing these printf's so we can reject designs with their use instead of silently handling them "incorrectly".
Good parts of this inspired by suggestion on that PR: #7010 (comment) .
This still breaks usage with even recent Chisel, but compared to 7010 informs the user they've used something that doesn't work anymore.