Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Reject intrinsic modules >= 4.0.0 #7009

Merged
merged 2 commits into from
May 19, 2024

Conversation

dtzSiFive
Copy link
Contributor

chipsalliance/firrtl-spec#210

Should not merge until/if they're removed from spec, but it's ready when we are.

Follow-on "eventually" would be dropping them from our IR / rejecting on all versions.

@dtzSiFive dtzSiFive force-pushed the feature/intrinsic-module-deprecated branch from 852d069 to 3a29dcd Compare May 8, 2024 21:43
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dtzSiFive dtzSiFive merged commit 3f6b9fa into llvm:main May 19, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the feature/intrinsic-module-deprecated branch May 19, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants