[FSM]New builders for StateOp and TransitionOp. #6991
+47
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Create an OutputOp inside a StateOp with the output values instead of an empty OutputOp, which needs to be erased after all. 2. Accept two functions as arguments to create the TransitionOp, which is similar to the creation of sv::IfOp. This would be helpful because one doesn't have to create the blocks and set the insertion point manually, which may cause errors sometime.
HahaLan97
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateOp, which also takes a ValueRange and uses it to create theOutputOpwith it.TransitionOpto be able to take twostd::function<void>as arguments, which are similar to thesv::IfOpand are by default null. Which means, this change doesn't affect anything already existed.These are simple changes, but would be very helpful when creating these two ops. One doesn't have to always use
ensureGuardandensureActionto create the blocks and set the InsertionPoint. Don't mention thatensureGuardcreates an emptyReturnOp, which in most cases need to be erased every time. The emptyOutputOpcreated in StateOp is in most cases useless as well.