Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boot ms #533

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Fix boot ms #533

merged 6 commits into from
Apr 19, 2024

Conversation

0xcadams
Copy link
Member

Description

Fixed metrics to report preloadTime as the time between connecting addMediaMetrics and the first play event.

@0xcadams 0xcadams requested a review from a team as a code owner April 18, 2024 22:48
Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coinbase-lvpr-tv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:51pm
lvpr-tv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:51pm
ui-kit-docs-embed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:51pm
ui-kit-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:51pm
ui-kit-next-pages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:51pm
ui-kit-with-pubnub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:51pm

@0xcadams 0xcadams merged commit c0aa640 into main Apr 19, 2024
14 checks passed
@0xcadams 0xcadams deleted the 0xcadams/boot-ms branch April 19, 2024 02:03
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
0xcadams added a commit that referenced this pull request Apr 24, 2024
* Fix boot ms (#533)

* fix: moved boot time into addmediametrics

* chore: changeset

* test: fix tests

* test: fix tests

* test: fix

* test: remove flaky test

* chore: version packages (#534)

* chore: version packages

* ci: bump

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chase Adams <c@cadams.io>

* fix: resolve issue with onError (#535)

* chore: version packages (#536)

* chore: version packages

* ci: bump

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chase Adams <c@cadams.io>

* iframe Force Enabled (#537)

* fix: force enabled

* fix: default to true

* fix: added hideEnabled

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant