Add upload to IPFS on create #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…0xcadams/use-create-asset
Merged
victorges
reviewed
Mar 21, 2023
| @@ -15,6 +15,7 @@ import { publicProvider } from 'wagmi/providers/public'; | |||
| const livepeerClient = createReactClient({ | |||
| provider: studioProvider({ | |||
| apiKey: process.env.NEXT_PUBLIC_STUDIO_API_KEY ?? '', | |||
| baseUrl: 'https://livepeer.monster/api', | |||
There was a problem hiding this comment.
@0xcadams Is this on a public documentation/example? If so, we should avoid directing users to use our staging environment which is internal only (especially cause we don't have any restrictions today like only allowing livepeer.org emails). Is it possible to use prod here?
There was a problem hiding this comment.
Those apps preceded by underscore are internal apps for developers, so no, it's not docs
|
Cool!
…On Tue, Mar 21, 2023, 17:43 Chase Adams ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/_next/src/pages/_app.tsx
<#297 (comment)>:
> @@ -15,6 +15,7 @@ import { publicProvider } from 'wagmi/providers/public';
const livepeerClient = createReactClient({
provider: studioProvider({
apiKey: process.env.NEXT_PUBLIC_STUDIO_API_KEY ?? '',
+ baseUrl: 'https://livepeer.monster/api',
Those apps preceded by underscore are internal apps for developers, so no,
it's not docs
—
Reply to this email directly, view it on GitHub
<#297 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJ4R6EUHQ4SS3DNWFDTF3W5IHFLANCNFSM6AAAAAAV627OSM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added IPFS upload on creation of an asset, so no subsequent calls need to be made to upload to IPFS.
Related to livepeer/docs#355
Fixes https://linear.app/livepeer/issue/DX-104/add-upload-to-ipfs-in-usecreateasset