Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner: cron job for asset deletion #233

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Conversation

gioelecerati
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 84 lines in your changes are missing coverage. Please review.

Project coverage is 16.52123%. Comparing base (9703dbc) to head (fb5f49d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #233         +/-   ##
===================================================
- Coverage   17.37003%   16.52123%   -0.84880%     
===================================================
  Files             16          16                 
  Lines           1635        1719         +84     
===================================================
  Hits             284         284                 
- Misses          1326        1410         +84     
  Partials          25          25                 
Files Coverage Δ
task/runner.go 18.08511% <0.00000%> (-3.93562%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9703dbc...fb5f49d. Read the comment docs.

Files Coverage Δ
task/runner.go 18.08511% <0.00000%> (-3.93562%) ⬇️

@gioelecerati gioelecerati marked this pull request as ready for review March 14, 2024 13:36
@gioelecerati gioelecerati requested a review from a team as a code owner March 14, 2024 13:36
task/runner.go Outdated Show resolved Hide resolved
task/runner.go Outdated Show resolved Hide resolved
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all comments but some minor ones (tagging asset as deleted) are optional

task/runner.go Show resolved Hide resolved
task/runner.go Outdated Show resolved Hide resolved
task/runner.go Show resolved Hide resolved
task/runner.go Outdated Show resolved Hide resolved
task/runner.go Outdated Show resolved Hide resolved
@gioelecerati gioelecerati merged commit f0fbece into main Apr 29, 2024
13 checks passed
@gioelecerati gioelecerati deleted the gio/runner/cronjob-delete branch April 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants