Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Attempt processing recording up to 5 times #2119

Merged
merged 1 commit into from Apr 2, 2024

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

We had only 1 retry and are seeing a couple errors in prod with sessions that don't
get processed on that time.

I believe stream-info-service is likely getting delayed and bumping the lastSeen of
the stream after it is done.

By increasing the amount of retries here, we effectively give more time for the system
to stabilize and stop updating the stream that just stopped. It should mitigate some of
the errors, but the real fix is gonna be #2013

Specific updates (required)

  • Attempt processing recordings up to 5 times

How did you test each of these updates (required)
Nah

Does this pull request close any open issues?
Fixes PS-369 and PS-424

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner March 28, 2024 22:21
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview Mar 28, 2024 10:21pm

@victorges victorges changed the title api: Retry processing recording up to 4 times api: Attempt processing recording up to 5 times Mar 28, 2024
@emranemran emranemran merged commit 1fa939f into master Apr 2, 2024
13 checks passed
@emranemran emranemran deleted the vg/fix/session-recording branch April 2, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants