access-control: better logs & dashboard update #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
approved these changes
Dec 11, 2023
| @@ -138,9 +138,14 @@ app.post( | |||
| if ( | |||
| playbackPolicyType !== "public" && | |||
| req.body.pub === req.config.accessControlAdminPubkey && | |||
| req.config.accessControlAdminPubkey !== "" && | |||
| req.config.accessControlAdminPubkey && | |||
There was a problem hiding this comment.
This check already contains the above since "" is falsy
$ node
Welcome to Node.js v21.4.0.
> if ("") {
... console.log("true")
... } else {
... console.log("false")
... }
false
| req.body.pub !== "" && | ||
| req.body.pub | ||
| ) { | ||
| console.log( | ||
| `access-control: gate: allowing admin access for contentId=${content.id} playbackId=${playbackId}, user=${user.id} is admin, pubKey=${req.config.accessControlAdminPubkey} is adminPubKey` |
There was a problem hiding this comment.
Hmm, this part is weird: user=${user.id} is admin
Shouldn't you actually log user.admin here? I don't think there's a guarantee on user being an admin here (in fact its probably not, since it's the owner of the video, not the caller)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist