vod: specify content-length when creating presigned urls #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gioelecerati
force-pushed
the
gio/vod/content-length-presigned-url
branch
from
6732165
to
1984ac9
Compare
victorges
approved these changes
Oct 17, 2023
Comment on lines
+1074
to
+1081
| if (!res.headersSent) { | ||
| res.status(403); | ||
| res.end(); | ||
| proxyRes.end(); | ||
| } else { | ||
| res.end(); | ||
| proxyRes.end(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!res.headersSent) { | |
| res.status(403); | |
| res.end(); | |
| proxyRes.end(); | |
| } else { | |
| res.end(); | |
| proxyRes.end(); | |
| } | |
| if (!res.headersSent) { | |
| res.status(403); | |
| } | |
| res.end(); | |
| proxyRes.end(); |
| proxy.on("error", function (err, req, proxyRes) { | ||
| console.error("Proxy error:", err); | ||
| if (!res.headersSent) { | ||
| res.status(403); |
There was a problem hiding this comment.
would this work?
Suggested change
| res.status(403); | |
| res.status(proxyRes.status); |
| Bucket: config.bucket, | ||
| Key: objectKey, | ||
| }); | ||
| ContentLength: null, |
There was a problem hiding this comment.
Could be just ContentLength: contentLength || null
Comment on lines
+923
to
+924
| contentLength: | ||
| type: number |
There was a problem hiding this comment.
This should be in api-schema since its public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is coming out of nothing, just a thing that came to my mind.
With this, we allow developers to specify a
contentLengthparameter in therequest-uploadapi that generates presigned URLs.This way, that URL is going to be valid exclusively for files with that exact size in bytes.
This enables tier enforcing for platforms, for example, a platform providing free tier functionalities with a max asset size of 50MB for users would generate the presigned URL in the backend collecting the content-length of the user file and providing it to our function.
If the user tries to upload a different file, a 403 status code would get returned.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist