Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai): introduce AIServiceRegistry contract (proxy version) #643

Closed
wants to merge 1 commit into from

Conversation

rickstaa
Copy link
Contributor

What does this pull request do? Explain your changes. (required)

This pull request introduces the AIServiceRegistry contract. This contract serves as a registry for AI subnet orchestrators, enabling them to register and make their services discoverable within the AI subnet.

Specific updates (required)

  • A deployment script was added to deploy a AIServiceRegistry proxy and target contract linked to the mainnet controller contract.
  • Information about the deployed contracts was commited to the deployments directory.

How did you test each of these updates (required)

I ensured that all tests passed. Deployed the contract and interacted with the contract using foundry cast.

Test Deployments

Does this pull request close any open issues?

https://linear.app/livepeer-ai-spe/issue/LIV-90/design-and-implement-solution-for-advertising-separate-service-uri-for

Checklist:

  • README and other documentation updated
  • All tests using yarn test pass

This commit adds the AIServiceRegistry contract, facilitating the
registration and discoverability of AI subnet orchestrators'
services.
const {deployer} = await getNamedAccounts() // Fetch named accounts from hardhat.config.ts

const contractDeployer = new ContractDeployer(deployer, deployments)
const controller = await contractDeployer.fetchDeployedController()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we don't directly interact with the controller by registering contracts, theoretically, we could simply utilize deployments.get("Controller"). However, I've retained this part in the script for two reasons: firstly, in case people wish to extend this deployment script later on, and secondly, to maintain consistency with other proxy deployment scripts like deploy_bonding_votes.ts.

@rickstaa rickstaa marked this pull request as draft April 19, 2024 00:12
@rickstaa
Copy link
Contributor Author

Closed in favor of #642 (see #642 (comment)).

@rickstaa rickstaa closed this Apr 22, 2024
@rickstaa rickstaa deleted the add_ai_service_registery_proxy branch April 22, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant