Add check for null address in addSolver

livepeer · Jan 15, 2018 · b09add6 · b09add6
1 parent 291a544
commit b09add6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/contracts/verification/LivepeerVerifier.sol b/contracts/verification/LivepeerVerifier.sol
@@ -56,6 +56,8 @@ contract LivepeerVerifier is Manager, IVerifier {
     }
 
     function addSolver(address _solver) external onlyControllerOwner {
+        // Must not be null address
+        require(_solver != address(0));
         // Must not already be a solver
         require(!isSolver[_solver]);
 

diff --git a/verification_test/LivepeerVerifier.js b/verification_test/LivepeerVerifier.js
@@ -38,6 +38,10 @@ contract("LivepeerVerifier", accounts => {
     })
 
     describe("addSolver", () => {
+        it("should fail for null address", async () => {
+            await expectThrow(verifier.addSolver("0x0"))
+        })
+
         it("should fail if solver is already whitelisted", async () => {
             await expectThrow(verifier.addSolver(accounts[0]))
         })