Fix runtime error in aiWorker when pricePerUnit is unset #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliteprox
changed the title
rickstaa
requested changes
May 20, 2024
This commit ensures that when the `transcodePrice` is not set by the AI orchestrator no `nil` error is thrown when a Gateway requests the orchestrators OrchInfo.
This commit fixes the check that is performed to check if transcodePrice is set.
Tested transcoding with `-pricePerUnit` and `-pricePerBroadcaster`, verified the correct price comes through. Tested AI jobs with and without pricePerUnit, in every case the price from the model is used and no nil errors occur. Tested without `-autoAdjustPrice=false` so that it would reach the line it was previously breaking on. Everything looks good.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes a fatal runtime error when
-pricePerUnitis not set, which is allowed with-aiWorkerflag in #3047Specific updates (required)
-pricePerUnitwhen-aiWorkeris not setHow did you test each of these updates (required)
-pricePerBroadcasterprices are set correctly for transcoding work-pricePerUnitprice is used for transcode jobs when-pricePerBroadcasteris unset for the broadcasting address-autoAdjustPricestill works correctly in all casesDoes this pull request close any open issues?
#3057
Checklist:
makeruns successfully./test.shpass