Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create option to filter Os by min livepeer version used #3050

Merged
merged 12 commits into from May 13, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented May 9, 2024

Add the ability to specify by Broadcaster the minimum acceptable go-livepeer version from Os. It works in the following manner:

  1. Broadcaster specifies a flag -orchMinLivepeerVersion 4.3.1
  2. During the discovery/selection process, B excludes all Os with the version below 4.3.1
  3. In the case of O/T topology, the version of O is taken into consideration, then while serving a segment, O will reject Ts that didn't upgrade.

@leszko leszko changed the title rafal/filter-o-by-livepeer-version Create option to filter Os by min livepeer version used May 9, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 76.74419% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 57.37820%. Comparing base (6e49ae2) to head (f83dce8).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3050         +/-   ##
===================================================
+ Coverage   57.32866%   57.37820%   +0.04954%     
===================================================
  Files             92          92                 
  Lines          15685       15722         +37     
===================================================
+ Hits            8992        9021         +29     
- Misses          6091        6099          +8     
  Partials         602         602                 
Files Coverage Δ
cmd/livepeer/livepeer.go 50.33113% <100.00000%> (+0.33113%) ⬆️
core/livepeernode.go 68.18182% <100.00000%> (ø)
core/orchestrator.go 78.31933% <100.00000%> (+0.07312%) ⬆️
server/broadcast.go 80.00000% <100.00000%> (+0.04310%) ⬆️
server/mediaserver.go 67.50484% <100.00000%> (+0.03146%) ⬆️
core/capabilities.go 83.69565% <86.20690%> (+0.16151%) ⬆️
cmd/livepeer/starter/starter.go 7.15005% <0.00000%> (-0.02892%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e49ae2...f83dce8. Read the comment docs.

Files Coverage Δ
cmd/livepeer/livepeer.go 50.33113% <100.00000%> (+0.33113%) ⬆️
core/livepeernode.go 68.18182% <100.00000%> (ø)
core/orchestrator.go 78.31933% <100.00000%> (+0.07312%) ⬆️
server/broadcast.go 80.00000% <100.00000%> (+0.04310%) ⬆️
server/mediaserver.go 67.50484% <100.00000%> (+0.03146%) ⬆️
core/capabilities.go 83.69565% <86.20690%> (+0.16151%) ⬆️
cmd/livepeer/starter/starter.go 7.15005% <0.00000%> (-0.02892%) ⬇️

@leszko leszko marked this pull request as ready for review May 10, 2024 15:11
@leszko leszko requested review from thomshutt and mjh1 May 10, 2024 15:11
server/broadcast.go Outdated Show resolved Hide resolved
@leszko leszko merged commit 133ca8b into master May 13, 2024
18 checks passed
@leszko leszko deleted the rafal/filter-o-by-livepeer-version branch May 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants