Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payments processed log line #2968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ad-astra-video
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Updates ticket processed log line to report faceValue and winProb used for each ticket since they are the same for all tickets. Total s are used for tickets count and ticketEV.

@stronk-dev let me know if this works or have any feedback.

Specific updates (required)

  • Updates summary log line for tickets

Does this pull request close any open issues?
#2961

Checklist:

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.36459%. Comparing base (9ed49d8) to head (fa0c520).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2968         +/-   ##
===================================================
- Coverage   57.37567%   57.36459%   -0.01108%     
===================================================
  Files             89          89                 
  Lines          15402       15398          -4     
===================================================
- Hits            8837        8833          -4     
  Misses          5973        5973                 
  Partials         592         592                 
Files Coverage Δ
core/orchestrator.go 78.09847% <100.00000%> (-0.14774%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed49d8...fa0c520. Read the comment docs.

Files Coverage Δ
core/orchestrator.go 78.09847% <100.00000%> (-0.14774%) ⬇️

@leszko
Copy link
Contributor

leszko commented Feb 26, 2024

I like the new logging message. @ad-astra-video and @stronk-dev let me know when you tested it, then I'll review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants