Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.5.38 #2753

Merged
merged 2 commits into from Feb 15, 2023
Merged

release v0.5.38 #2753

merged 2 commits into from Feb 15, 2023

Conversation

thomshutt
Copy link
Contributor

@thomshutt thomshutt commented Feb 10, 2023

v0.5.38

Breaking Changes 🚨🚨

None

Bug Fixes 🐞

Broadcaster

  • #2709 Add logging for high keyframe interval, reduce log level for discovery loop
  • #2684 Fix transcode success rate metric
  • #2740 Fix incorrect processing of VerificationFreq parameter
  • #2735 Fix EndTranscodingSession() call and potential race
  • #2747 Fixed a transcoding bug that occurred when remote transcoder was removed

General

  • #2713 Add support for keyfiles with -ethKeystorePath, update flag descriptions, flagset output to stdout

@leszko
Copy link
Contributor

leszko commented Feb 13, 2023

@thomshutt
Copy link
Contributor Author

@leszko I did consider that, but wasn't sure how long it'd be until they're merged

@eliteprox
Copy link
Contributor

@leszko I did consider that, but wasn't sure how long it'd be until they're merged

Both #2713 and #2747 ready for review again

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #2753 (1baa891) into master (f6d88fd) will increase coverage by 0.04643%.
The diff coverage is n/a.

❗ Current head 1baa891 differs from pull request most recent head d4d8ca9. Consider uploading reports for the commit d4d8ca9 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2753         +/-   ##
===================================================
+ Coverage   56.30182%   56.34825%   +0.04643%     
===================================================
  Files             88          88                 
  Lines          19177       19147         -30     
===================================================
- Hits           10797       10789          -8     
+ Misses          7788        7767         -21     
+ Partials         592         591          -1     
Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 2.85189% <0.00000%> (-1.44149%) ⬇️
cmd/livepeer/livepeer.go 47.59358% <0.00000%> (+0.25315%) ⬆️
core/orchestrator.go 78.20690% <0.00000%> (+0.27394%) ⬆️
common/util.go 61.58537% <0.00000%> (+1.28686%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d88fd...d4d8ca9. Read the comment docs.

Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 2.85189% <0.00000%> (-1.44149%) ⬇️
cmd/livepeer/livepeer.go 47.59358% <0.00000%> (+0.25315%) ⬆️
core/orchestrator.go 78.20690% <0.00000%> (+0.27394%) ⬆️
common/util.go 61.58537% <0.00000%> (+1.28686%) ⬆️

@thomshutt
Copy link
Contributor Author

@leszko those two PRs are now in

@thomshutt thomshutt merged commit a8f3f4e into master Feb 15, 2023
@thomshutt thomshutt deleted the release-0.5.38 branch February 15, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants