Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalyst-node: handle vod source urls without hitting load-balancer #177

Merged
merged 1 commit into from Sep 29, 2022

Conversation

emranemran
Copy link
Contributor

No description provided.

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's also add an issue to track using a shared def for stream prefixes so we don't need to manage stream prefixes here as well as in https://github.com/livepeer/catalyst-api/blob/main/config/stream_names.go#L12

@yondonfu
Copy link
Member

Looks like the Drone build is failing, but they've been failing for all PRs even before this one...Let's look into that separately.

@emranemran
Copy link
Contributor Author

LGTM!

Let's also add an issue to track using a shared def for stream prefixes so we don't need to manage stream prefixes here as well as in https://github.com/livepeer/catalyst-api/blob/main/config/stream_names.go#L12

Filed #178

@emranemran
Copy link
Contributor Author

Looks like the Drone build is failing, but they've been failing for all PRs even before this one...Let's look into that separately.

Yeah this one needs to be looked at - these failures have been consistent and fairly random for several weeks now.

@emranemran emranemran merged commit 3aec869 into main Sep 29, 2022
@emranemran emranemran deleted the emran/handle-vod-transcode-catalyst-node branch September 29, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants