Add setting to enable font ligatures in the code editor #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
assets/js/lib/settings.js
Outdated
| const DEFAULTSETTINGS = { | ||
| editor_auto_completion: true, | ||
| editor_auto_signature: true, | ||
| editor_font_size: EDITOR_FONT_SIZE.normal, | ||
| editor_theme: EDITOR_THEME.default, | ||
| editor_ligatures: EDITOR_LIGATURES.off, |
There was a problem hiding this comment.
I would just make it a boolean, like editor_auto_completion :)
|
@JBraungardt sounds good, just one comment and we can ship it! FTR we intentionally disable it by default, so that people new to Elixir are not confused with |
|
Uffizzi Preview |
jonatanklosko
approved these changes
May 17, 2024
There was a problem hiding this comment.
@JBraungardt perfect!
Looks like you need to sign CLA with the other account that you pushed. Or perhaps you can squash and force push with the first one :)
Done |
jonatanklosko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As jetbrains-mono is used as the default font in the codemirror editor and this font has support for ligatures a new setting is added to enable rendering with ligatjures.
The default for this setting is off so that the current behavior is maintained.