-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compliance tests to docs! #2021
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2021 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 104 104
Lines 11622 11622
Branches 2910 2910
=======================================
Hits 9378 9378
Misses 1701 1701
Partials 543 543 ☔ View full report in Codecov by Sentry. |
This is awesome, v much what I had in mind. Also multiple ways to slice and dice this - e.g. by generator/framework I was wavering as to whether this should be into the main site or whether it might be better to have its own repo site |
i'm still wrapping my head around the format of it, but we could make some helper functions to be able to pull and summarize compliance tests for a given generator (similar to my crude attempt in
up to you! it sorta makes sense to me to be in the main docs since the test results will already by in this repo, but wouldn't be that hard to make a second site. I think we have plenty of room in the toctree for tests as their own section if we want it that way! |
The main reason I was tending towards a separate repo is because I think we'd want to check in all of the generated artefacts - or at least embed. And that is gonna be big, and get bigger... |
I think as this is only committing a TSV it doesn't prevent us from going the route of a second repo later |
Following #2018
i think it would be really cool for the compliance test results to be in the docs.
This is a ~ draft ~ intended for ~ further input ~ and is just supposed to be a starting point to see what we want!
Here what i've done is
output
directory to signal that they should be versioned (so that the docs can see them without needing to run all the tests, but also without committing the entireoutput
directory)conf.py
to expose that data in a jinja contextcore
compliance tests for how we could have summary and expanded detail data for each test.pretty ugly right now! but just a starting point!
So we end up with something like this for the summary:
and something like this for the
core
compliance test, where for each schema within a test you get a table of resultsTODO
coverage
file that's generated, we could use the sphinxindex
directive to show all the tests that are related to each metamodel term