Move sort classes from python generators to linkml-runtime #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore original schemaloader code in Generator... too much type negotiation in there to simplify lol
|
+1 for this. I see this problem a lot with gendoc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can only be merged after:
Starting to tidy up pydanticgen, noticed first off a
TODOsaying that the sort classes method should move to schemaview. definitely agreed.removed it and the identical one from the python generator and updated the places where it's called.
Other changes: I also noticed i wasnt' getting type hints for
self.schemafrom the parent Generator class, so i went looking for why, and in the process of adding the hint noticed that the init from schemaloader method had some redundancies and cleaned them up.