Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: test pythongen forward reference bug. #1169

Closed
wants to merge 1 commit into from
Closed

Conversation

cmungall
Copy link
Member

When this PR is merged, it fixes #1168

When this PR is merged, it fixes #1168
@codecov-commenter
Copy link

Codecov Report

Merging #1169 (2948a85) into main (58550cc) will increase coverage by 0.27%.
The diff coverage is 87.64%.

@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
+ Coverage   78.16%   78.43%   +0.27%     
==========================================
  Files          74       74              
  Lines        8465     8599     +134     
  Branches     2027     2116      +89     
==========================================
+ Hits         6617     6745     +128     
- Misses       1453     1454       +1     
- Partials      395      400       +5     
Impacted Files Coverage Δ
...tors/sqlalchemy/sqlalchemy_declarative_template.py 100.00% <ø> (ø)
linkml/generators/jsonschemagen.py 87.84% <86.74%> (-4.12%) ⬇️
linkml/utils/generator.py 86.11% <100.00%> (+1.10%) ⬆️
linkml/utils/converter.py 51.45% <0.00%> (-0.51%) ⬇️
linkml/generators/prefixmapgen.py 73.11% <0.00%> (ø)
linkml/generators/oocodegen.py 93.28% <0.00%> (+0.05%) ⬆️
linkml/generators/sqlddlgen.py 83.45% <0.00%> (+0.05%) ⬆️
linkml/generators/docgen.py 86.35% <0.00%> (+0.10%) ⬆️
linkml/generators/csvgen.py 98.07% <0.00%> (+0.11%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cmungall cmungall changed the title WIP: forward reference bug. WIP: test pythongen forward reference bug. Jan 20, 2023
@sierra-moxon
Copy link
Member

closing this PR as it is a yaml example file and a test with no asserts -- I think this is because this was already fixed in another PR and this is redundant. please of course reopen if I got this wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detection of forward references may sometimes be incorrect in pythongen
3 participants