-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bokeh 3.4.0 deprecation warnings for circle()
, cross()
#1428
Fix bokeh 3.4.0 deprecation warnings for circle()
, cross()
#1428
Conversation
@Nschanche A small fix that has no surprise. I intend to merge this PR in the next few days. |
The required bokeh version for lightkurve appears to be 2.0.0. Adding multiple marker types seems to have been added to bokeh in 2.4.3, so we should probably change the requirement in the toml file before merging. |
Good catch! The minimum bokeh requirement is raised to 2.3.2.
An alternative is to raise the minimum bokeh requirement to 2.4.3, given it is the oldest release that still has documentation readily available. |
…nose problems - e.g., if the user has an old version of bokeh that is incompatible with others, such as jinja2
980eb8f
to
47cb3d2
Compare
An additional commit is made to tweak how Currently, if there is any error during bokeh import, It could lead to confusion when users do have bokeh installed, but there is some other issues during import. E.g., if users have old bokeh v2.3.0 installed along with some recent version of jinja2 (the two are not compatible), calling -> 1347 output_notebook(verbose=False, hide_banner=True)
1348 return show(create_interact_ui, notebook_url=notebook_url)
NameError: name 'output_notebook' is not defined The commit changes it so that it displays the actual import error when calling The interact() tool requires the `bokeh` Python package; you can install bokeh using e.g. `conda install bokeh`.
---------------------------------------------------------------------------
ImportError Traceback (most recent call last)
Cell In[2], line 10
...
...
File C:\pkg\_winNonPortables\miniforge3\envs\lk_dev\lib\site-packages\bokeh\core\templates.py:42
39 from os.path import dirname, join
41 # External imports
---> 42 from jinja2 import Environment, FileSystemLoader, Markup
44 #-----------------------------------------------------------------------------
45 # Globals and constants
46 #-----------------------------------------------------------------------------
48 __all__ = (
49 'AUTOLOAD_JS',
50 'AUTOLOAD_NB_JS',
(...)
63 'SCRIPT_TAG',
64 )
ImportError: cannot import name 'Markup' from 'jinja2' (C:\pkg\_winNonPortables\miniforge3\envs\lk_dev\lib\site-packages\jinja2\__init__.py) |
Close #1424
Manually tested on bokeh 3.4.1 and bokeh 2.4.3 . No regression found.
changelog:
- Fixed interact features, e.g. ``tpf.interact()``, to be compliant with Bokeh v3.4.0. The minimum Bokeh version is raised to v2.3.2 accordingly. [#1428]