Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1302 qualityflag #1415

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Nschanche
Copy link
Collaborator

Added new quality flags to the default exclude. See issue #1302.

@Nschanche
Copy link
Collaborator Author

Nschanche commented Mar 14, 2024

This fails the following test.

    \#SAP_FLUX has a worse score (<0.95) because it hasn't been corrected
    lc_sap = lc_pdcsap.copy()
    lc_sap.flux = lc_pdcsap.sap_flux
    lc_sap.flux_err = lc_pdcsap.sap_flux_err
    assert underfit_metric_neighbors(lc_sap, min_targets=3, max_targets=3) < 0.95

The new flags remove 7048/18749 (the previous default removed 562/18749). The underfit_metric_neighbors is now 0.9924204310399938, which does not pass the assertion (previous underfit_matric_neighbors was 0.9259854773984688)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant