Added fixes for some bugs in the to_fits
methods of LightCurve classes
#1345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs in the
LightCurve
,KeplerLightCurve
, andTESSLightCurve
to_fits
methods and the tests. This ensures users can pass extra keyword arguments.@Nschanche points out that it's odd that, by default,
to_fits
doesn't save every column. Some of the columns can be a bit superfluous, so I'm not sure of a neat way forward here. What do people think, shouldto_fits
save all columns by default?