Modified CDIPS output to present flux values and BTJD time #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lightkurve/io/cdips.py
Outdated
| @@ -63,6 +69,11 @@ def read_cdips_lightcurve(filename, | |||
| quality_column=quality_column, | |||
| time_format='btjd') | |||
|
|
|||
| #The time displayed is in BJD not BTJD. We can fix this by subtracting | |||
| # 2457000 | |||
| lc["time"] = lc["time"]-2457000 | |||
There was a problem hiding this comment.
This should be taken care of with the time_format argument by setting it to jd
There was a problem hiding this comment.
This has now been adjusted. Thank you.
There was a problem hiding this comment.
Note however that the time is given in BJD, but this does not seem to be an option.
src/lightkurve/io/cdips.py
Outdated
| lc.meta["AUTHOR"] = "CDIPS" | ||
| lc.meta['TARGETID'] = lc.meta.get('TICID') | ||
| lc.meta['QUALITY_BITMASK'] = 36 |
There was a problem hiding this comment.
The bitmask needs to be updated
There was a problem hiding this comment.
Is the point here to change the quality bitmask to the TESS default i.e., 175?
There was a problem hiding this comment.
Additionally CDIPS light curves have already had quality filtering applied, and do not provide the bitflags necessary for a user to apply a new bitmask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR in response to issue #1067
I have modified the cdips.py code to show the correct BTJD. I have also made IFL1 the default flux and IFE1 the default flux error.
Note that a user can still change this value back to mag or anyone of the other flux values, they just need to specify that column when downloading.
Showing the flux_error is now set as a default.
There is still an issue about what to put for the quality values. As is this is set to G for good values and X for bad. The data is filtered to only show the good data, so G is always only what is shown. Would it be better to set this to 0, this would make it more consistent with other light curve data.