-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update interact.py #1332
base: main
Are you sure you want to change the base?
Update interact.py #1332
Conversation
@vbkostov this is a great PR, if you can add in KIC/EPIC and make sure the proper motion is applied I'll review again! |
Updated interact.py to use: 1) TIC for plotting TESS targets 2) Gaia DR3 for plotting Kepler and K2
Fixed proper motion correction
Gaia DR3 used for TESS, Kepler, and K2. Proper motion correction fixed, not implemented properly.
Nice! 👍 |
I apologize for the belated reply.
|
A second thought, I wonder if we should allow the mismatch between cross-hair and the star's position, as the current cross-hair accurately reflects the position used by the mission operation. Any mismatch could help to diagnose some problems. For example, I just came across TIC 464378628, a star with very high proper motion (~2600 mas/yr in GAIA, but has no proper motion data in TIC catalog. The cross-hair is off by about 1 pixel from the actual star position (red arrow above). In this case, the mismatch helped me to identify some of the issues associated with SPOC lightcurves / TCEs.
The comparable Swarthmore Finding Chart also uses the logic similar to the current one, i.e., it surfaces the mismatch. It does show a warning "TIC entry matching entered name is not closest to the center coords." A side note: for this target TIC 464378628, if one employs the logic proposed by this PR (plotting cross-hair based on the RA/DEC from the tpf file, with the proper motion of the closest Gaia entry), the cross-hair would still be way off (in a different direction). |
@rebekah9969 is working on PR #1366 that will incorporate the PM for all targets in the TPF. This could be used to show both the fixed TIC location and the expected location at the time of observation. |
Nschanche, so is it the plan that once #1366 is done, it will replace the current search-neighbor-Gaia DR2 logic in |
Some targets, including high-proper motion stars, show a mismatch between the cross-hair and the star's position on interact_sky(). The mismatch is also present for all or most of the nearby stars.
Examples include "duplicate" or "split" IDs (e.g. TIC 150391195), high-proper stars (e.g. TIC 228760807), and other targets that do not have duplicates, splits, or high proper motion (e.g. TIC 294183478).
This is a proposed solution, where interact.py uses the GaiaDR3 catalog instead of the GaiaDR2 catalog to plot stars' positions, both for TESS and for Kepler/K2. The result is an effectively exact match between the cross-hair and the target's position for low proper-motion stars, and much closer match for high-proper motion stars.
Also, the proper motion correction is not applied due to a bug. This is now fixed and the correction is properly implemented.