Addressing github issue 1278 #1330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfm
reviewed
May 2, 2023
| lc_vstack = vstack(lcs, join_type="outer", metadata_conflicts="silent") | ||
| for col in lc_vstack.columns: | ||
| if col not in ['time','flux','flux_err']: | ||
| lc_vstack[col] = lc_vstack[col].value.filled(-999) |
There was a problem hiding this comment.
I don't love this approach of using -999 as a magic number! What about using something like:
lc_vstack[col].fill_value = np.nanin the cases when there is missing data?
There was a problem hiding this comment.
I definitely agree, we did try that but the problem is that it only works when the column datatype is float, and some of the columns in the lightcurve objects have int datatypes. But hard coding in the -999 didn't feel great either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #1278 ,
stitch()now saves all columns from all component lightcurves in the stitched lightcurve. If a column is missing from one of the component lightcurves, all its will be filled with -999. This also helps with saving and reading in .fits files since it preserves relevant columns across Kepler/TESS/simulated lightcurve objects.