Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc build fixes: pin pydata theme version, pre execute ipynbs #1283

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

orionlee
Copy link
Collaborator

@orionlee orionlee commented Feb 24, 2023

  1. Pin pydata theme to v0.8.1 due to issues with the latest version.
  2. Provide a way to pre-execute ipynbs for doc build, to avoid the problem of intermittent errors from MAST breaking the build. See the instructions in docs/pre_execute_ipynbs.py for detials.

Issues with the latest pydata theme v0.12.0

Pinning pydata theme to v0.8.1 (and indirectly the sphinx 4.5.0) to temporarily work around the problem.

@orionlee
Copy link
Collaborator Author

This PR is based on v2.4.0 tag , thus creating some conflicts with main. Let me know if you'd prefer I rebase the PR to main.

@christinahedges
Copy link
Collaborator

Hi @orionlee I made some edits to your PR just to add some log messages to make it easier to see how much the script has to be rerun. I also added it in a makefile and I'm going to see if this does make it easier to run our notebook/docs.

It does look like I messed up the rebase though and I got myself a bit confused. Sorry I've made a mess here I'll try to clean it up!

@christinahedges christinahedges added the 💪 WIP This is a work in progress! label Apr 25, 2023
@christinahedges christinahedges self-assigned this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 WIP This is a work in progress!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants