New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make data product reader more modular #1237

Draft

orionlee wants to merge 2 commits into lightkurve:main from orionlee:make_reader_more_modular

Collaborator

orionlee commented Jul 7, 2022 •

edited

It is a refactoring to make adding new data products easier.
In the current draft, QLP is used as an illustration.

All data product specific information is encapsulated in the [data-product].py module.
1-line registration in io/__init__.py via the new register_data_product() function.
One would no longer need to change detect.py, search.py and read.py when a new data product is to be added.
Additionally, lightkurve users could add additional data products.

Feedback would be appreciated, before I proceed any further.


          make reader more modular - prototype

b2f2ae9

orionlee requested a review from barentsen

July 7, 2022 15:52


          make reader spec a type

19ec0f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment