Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpf.interact() and lc.interact_bls(): handle bokeh deprecation of circle() starting v3.4.0 #1424

Closed
orionlee opened this issue Apr 29, 2024 · 0 comments · Fixed by #1428
Closed
Assignees
Labels
🥜 easy to close This is easy to close!

Comments

@orionlee
Copy link
Collaborator

orionlee commented Apr 29, 2024

Problem description

For bokeh-based tpf.interact() and lc.interact_bls(), the implementation should be updated to handle:

BokehDeprecationWarning: 'circle() method with size value' was deprecated in Bokeh 3.4.0 and will be removed, use 'scatter(size=...) instead' instead.

Additionally, tpf.interact_sky() emits 2 warnings

BokehDeprecationWarning: 'circle() method with size value' was deprecated in Bokeh 3.4.0 and will be removed, use 'scatter(size=...) instead' instead.
BokehDeprecationWarning: 'cross() method' was deprecated in Bokeh 3.4.0 and will be removed, use "scatter(marker='cross', ...) instead" instead.

Environment

  • lightkurve version (e.g. 1.0b6): 2.4.2
  • installation method (e.g. pip, conda, source): conda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥜 easy to close This is easy to close!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants