Proposal to support FA omega notation for parsing #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea, should be no problem to incorporate this notation into goslin. Any suggestion in which grammar to put? I would not want to create a complete new grammar for these lipid names? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The omega notation for FA double bond positions counting from the methyl end of the FA is predominantly used in biology and microbial FA composition reporting.
Example of nomenclature:
Many of these nomenclature examples result from FA FAME GC-MS analysis performed by DSMZ. Unfortunately, these names are not easily found in either LIPID MAPS, nor SwissLipids, even though their naming is not too far off what we already support.
According to the LipidWeb reference, the older omega nomenclature should be replaced with the n nomenclature:
https://www.lipidmaps.org/resources/lipid_web?page=lipids/fa-eic.html
We should try to provide normalization of both variants to the latest shorthand nomenclature.