Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stopping impersonation #15302

Closed
wants to merge 1 commit into from
Closed

Conversation

kraktus
Copy link
Member

@kraktus kraktus commented May 14, 2024

Bug introduced by stronger typing :yell-at-cloud:

Could bikeshed on stop/cancel/quit, chose one but I don't have any preference.

Bug introduced by stronger typing :yell-at-cloud:

Could bikeshed on stop/cancel/quit, chose one but I don't have any preference.
@kraktus
Copy link
Member Author

kraktus commented May 14, 2024

Another solution would have been to just change impersonate(UserStr("-")) to the value of the one currently impersonated.

ornicar added a commit that referenced this pull request May 15, 2024
@ornicar ornicar closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants