Lila search v3 #15279
Merged
Lila search v3 #15279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenguyenthanh
force-pushed
the
lila-search-v3
branch
from
206cc5d
to
f0b77e8
Compare
ornicar
added a commit
that referenced
this pull request
Jun 2, 2024
Fix json writer exception and other regression from #15279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For lichess-org/lila-search#190.
To try this, checkout that pr branch and run
sbt app/run. And it should just work.The second goal is making changes minimal(the first one of course is correctness). Changes are only in search* modules.
There will be follow up prs to make every thing cleaner