Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write() on windows uses int for byte counts, leading to errors with very wide (more than 1.5m pixels wide) images.
libvips was assuming posix:
But windows has:
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/write?view=msvc-170
We probably have some other int32 limits still :( we should make some test cases and do more investigation, especially on windows.
Referring discussion:
#3918 (comment)