Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal SDL_UpdateTextureFromSurface() #9822

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

1bsyl
Copy link
Contributor

@1bsyl 1bsyl commented May 17, 2024

Add internal SDL_UpdateTextureFromSurface().
Since, SDL_CreateTextureFromSurface() is a big function, this makes it more readable.
Currently this only splits and lets the function internal.

Also: maybe we want a future SDL_CreateStreamingTextureFromSurface() or other variants for creating textures.
So maybe something like: SDL_CreateTextureWithPropertiesFromSurface() ?
so I guess, this would be a first step to prepare this.

in SDL_UpdateTextureFromSurface():

  • it can resolve the ColorKey if needed. (was there)
  • update texture alpha modulation and turn off/on blending if needed (was there)
  • maybe some stuff from colorspace (was there)
  • could handle streaming/static texture (not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant