-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create super-linter.yml #9820
Open
Hawthorne001
wants to merge
4,626
commits into
libsdl-org:release-2.30.x
Choose a base branch
from
Hawthorne001:main
base: release-2.30.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create super-linter.yml #9820
+467,244
−532,649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this started off as a UTF-32 output, and I forgot to actually finish this off to encode back to UTF-8. Fixes libsdl-org#9607.
Trailing commas in enums is a C99 feature. This commit removes them in SDL headers for ANSI compatibility.
…re function isn't implemented. Some backends, such as Wayland, don't support explicit mouse capture, and thus don't implement the backend function to do so, but do set/unset the capture flag on button events to handle cases where a button is pressed and the pointer is dragged outside the window. If the backend doesn't support explicitly setting the mouse capture mode, manually clear the capture flag when the window has had the focus forcibly removed, to avoid sending bogus motion events as well as an assert condition.
…ry one on Windows. There is now a desktop bounds variable that could potentially be exposed in the API if we wanted.
…mented. The idea is that if you have a `typedef Uint32 MyFlags` that has a bunch of defines that are meant to be bitflags, you can pack them into the same wiki page automatically. This only works with `typedef`s that are _not_ struct/union/enums, and it only pulls in `#define` lines that immediately follow the typedef line. Even a blank line or a comment will signal to stop including lines for this page!
Closing a device file takes 0.01 to 0.5s, which can add up to significant startup delays. The udev classification does not require opening the actual device files, so, use it if possible, and only fall back to opening the device and probing otherwise. (cherry picked from commit 45b804c)
Replacing function call `kill(0, SIGINT);` with `(void)raise(SIGINT);` in file test/testlock.c. The `kill()` function is not available on Unix systems when compiling without system extensions enabled.
Reference Issue libsdl-org#9557. This lets SDL_AudioFormat have the `#if byteorder == lilendian` section.
…due to use of deprecated ALooper_pollAll replace ALooper_pollAll by ALooper_pollOnce
The structure of the existing loop makes the inner loop of the previous commit unnecessary.
Did an initial cleanup on the headers and wrote a few pieces of documentation, but this needs more work to fill out the documentation.
This isn't C++ code, so there's no need to append global symbols with two colons. It looks ugly. I _did_ leave them for actual C++ things in WinRT-specific comments and other places, like a reference to a Perl class thing. Also, even though it's not valid C, it's a useful expression to say `StructType::SpecificField`, so I left those alone, too.
… the shape protocol
DMG creation on macOS occasionally fails, so try multiple times https://gitlab.kitware.com/cmake/cmake/-/issues/25671
Added SDL_Vulkan_DestroySurface, its documentation and corresponding platform specific implementations. Fixed some header inclusion orders to improve consistency between platforms. Added TODOs regarding MetalView creation and destruction which will benefit from the new functionality.
What does this actually do? I don't see any linter output in the new job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Existing Issue(s)