wayland: Clean up tablet object management #9448
Open
+173
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a very nice cleanup at first glance, @Kontrabant-- I will find some time to have a closer look and test it out soon. |
- Use intrusive wl_list nodes instead of the generic list for tracking tablet objects. - Register listeners for tablet and pad objects, so they will be freed if dynamically released instead of being leaked. - Remove some unnecessary indirection involving the tool user data, when the same data is passed directly into the callbacks via the 'data' parameter. - Remove an unused parameter from the 'Wayland_get_current_pen' function. - Rename the 'tablet' member of the tool struct to 'tablet_input' since it is pointing to the tablet input manager and not an individual tablet object.
Kontrabant
force-pushed
the
wayland_pen_cleanup
branch
from
2655dbc
to
485108f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @creichen for testing and review