Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL log functions don't print the priority prefix #9425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slouken
Copy link
Collaborator

@slouken slouken commented Apr 2, 2024

Most of the time this is going to be "INFO", and most of the time they're just verbose and not helpful. If someone wants to know more about the priority, they can set a custom log function.

@libsdl-org/a-team, thoughts? Good change? Bad change?

Most of the time this is going to be "INFO", and most of the time they're just verbose and not helpful. If someone wants to know more about the priority, they can set a custom log function.
@madebr
Copy link
Contributor

madebr commented Apr 2, 2024

lgtm, perhaps something that needs to be added to the migration docs?

@Kontrabant
Copy link
Contributor

While I don't think that line after line of "INFO" is useful for normal log messages, prefixing errors can be helpful, as you can very easily locate the offending lines by searching for "error" in the console output or a log dump.

I'd say keep the prefixes for warnings and errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants