Added unit tests #1294
Open
Added unit tests #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
For my hobby project to create a Rust implementation of matter.js, I am creating unittests . The Javascript unittests are used to replicate the functionality in Rust. This way I can ensure that the code behaves in a simular fashion.
I have never done any opensource contributions, but I thought that my work could be of use to the community. As an example I have included the unittests for Vector.
The goal of the unittests is to take the current implementation as standard. So no tests should fail, but I have added a //TODO: comment when the behavior micht be less desireable. This could be if the code throws an error or calculates to NaN or Infinity.
In case this kind of work is appreciated I can commit the unittests for the rest of the code. To be clear here: I'm not ready yet.
As stated earlier: I have never done this before. That is why I have kept the Rust implementation private. I will make it public once it gets done, or if other people want to participate. For now it is just a hobby project, but I thought the Javascript code could be helpful.
Greetings,
Ger