Refactor sampling parameter handling #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests passing; however, linear params changed slightly
|
@jhod0 thanks a lot! This is super helpful. There are some tests failing in the CI. You can also test locally, e.g.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would continue the refactor of parameter handling implemented in #350
It will reimplement the following two parameter classes with the framework in
Sampling/param_group.py:Of course, this is low-priority. It adds no features but would hopefully ease maintenance in the future, and make it simpler to add new sampled parameters to these classes.
Just opening the PR for discussion